fix comparison when handling deflated data (ESPTOOL-287) #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle_flash_data should not be called if status < TINFL_STATUS_DONE, which meas decompress failed
github-actions
bot
changed the title
|
Hi @alvarolb, Thanks for your contribution, LTGM. No one has noticed this error for over 5 years! I've cherry-picked your commit into our internal review & merge queue, this PR will be updated when it merges. Radim |
|
I suppose no one noticed the error as it is a little bug that in the wort case will do one unnecessary write on the flash... but nothing else ;) |
dobairoland
pushed a commit
to espressif/esptool-legacy-flasher-stub
that referenced
this pull request
May 30, 2024
handle_flash_data should not be called if status < TINFL_STATUS_DONE, which means decompress failed Closes espressif/esptool#650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_flash_data should not be called if status < TINFL_STATUS_DONE, which meas decompress failed